From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE0iO-00048o-Kx for qemu-devel@nongnu.org; Tue, 18 Sep 2012 12:32:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TE0iH-0000WZ-Ca for qemu-devel@nongnu.org; Tue, 18 Sep 2012 12:32:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE0iH-0000WP-4l for qemu-devel@nongnu.org; Tue, 18 Sep 2012 12:31:53 -0400 Message-ID: <5058A1F2.9070909@redhat.com> Date: Tue, 18 Sep 2012 18:31:46 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1347952634-12286-1-git-send-email-kraxel@redhat.com> <1347952634-12286-4-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/9] move set_mouse + cursor_define callbacks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: "qemu-devel@nongnu.org" On 09/18/12 16:10, Stefano Stabellini wrote: > On Tue, 18 Sep 2012, Gerd Hoffmann wrote: >> When adding DisplayChangeListeners the set_mouse and cursor_define >> callbacks have been left in DisplayState for some reason. Fix it. >> >> Signed-off-by: Gerd Hoffmann > > This patch is good. > The one thing I don't like is dpy_cursor_define_supported, because it > enforces the idea that we cannot register/deregister > DisplayChangeListeners at run time. Theoretically a new > DisplayChangeListener that support cursor_define could show up at any > time. Depends on how it is used. qxl is fine, it uses dpy_cursor_define_supported only to skip some work in case nobody cares anyway. vmware_vga uses it to signal the capability to the guest, which obviously doesn't fly with displaysurfaces coming & going ... cheers, Gerd