qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Kevin Wolf <kwolf@redhat.com>, Jason Baron <jbaron@redhat.com>
Cc: agraf@suse.de, aliguori@us.ibm.com, qemu-stable@nongnu.org,
	armbru@redhat.com, qemu-devel@nongnu.org,
	alex.williamson@redhat.com, avi@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] ahci: fix cdrom read corruption
Date: Tue, 18 Sep 2012 18:44:12 +0200	[thread overview]
Message-ID: <5058A4DC.6030001@suse.de> (raw)
In-Reply-To: <502389E4.7020500@redhat.com>

Am 09.08.2012 11:59, schrieb Kevin Wolf:
> Am 03.08.2012 21:57, schrieb Jason Baron:
>> Hi,
>>
>> While testing q35 I found data corruption on reads from the cdrom on the ahci
>> controller. The first patch addresses this issue. I also noticed that there is
>> a memory leak in the ahci code, which is addressed in the second patch.
>>
>> Thanks,
>>
>> -Jason
>>
>>
>> v2:
>>     fprintf -> DPRINTF (so can't be triggered by guest)
>>     0 sglist fields
>>
>>
>> Jason Baron (2):
>>   ahci: Fix ahci cdrom read corruptions for reads > 128k
>>   ahci: Fix sglist memleak in ahci_dma_rw_buf()
>>
>>  dma-helpers.c     |    1 +
>>  hw/ide/ahci.c     |   44 +++++++++++++++++++++++++++++++++++++-------
>>  hw/ide/internal.h |    1 +
>>  3 files changed, 39 insertions(+), 7 deletions(-)
>>
> 
> Thanks, applied both to the block branch.

Thanks, backported both to stable-0.15 (avoiding the new DMA helpers and
GLib).

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      reply	other threads:[~2012-09-18 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 19:57 [Qemu-devel] [PATCH v2] ahci: fix cdrom read corruption Jason Baron
2012-08-03 19:57 ` [Qemu-devel] [PATCH 1/2 v2] ahci: Fix ahci cdrom read corruptions for reads > 128k Jason Baron
2012-08-03 19:57 ` [Qemu-devel] [PATCH 2/2 v2] ahci: Fix sglist memleak in ahci_dma_rw_buf() Jason Baron
2012-08-09  9:59 ` [Qemu-devel] [PATCH v2] ahci: fix cdrom read corruption Kevin Wolf
2012-09-18 16:44   ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5058A4DC.6030001@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=jbaron@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).