From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE0uM-0003Mu-EK for qemu-devel@nongnu.org; Tue, 18 Sep 2012 12:44:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TE0uG-0005IX-Mw for qemu-devel@nongnu.org; Tue, 18 Sep 2012 12:44:22 -0400 Message-ID: <5058A4DC.6030001@suse.de> Date: Tue, 18 Sep 2012 18:44:12 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <502389E4.7020500@redhat.com> In-Reply-To: <502389E4.7020500@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] ahci: fix cdrom read corruption List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Jason Baron Cc: agraf@suse.de, aliguori@us.ibm.com, qemu-stable@nongnu.org, armbru@redhat.com, qemu-devel@nongnu.org, alex.williamson@redhat.com, avi@redhat.com, pbonzini@redhat.com Am 09.08.2012 11:59, schrieb Kevin Wolf: > Am 03.08.2012 21:57, schrieb Jason Baron: >> Hi, >> >> While testing q35 I found data corruption on reads from the cdrom on t= he ahci >> controller. The first patch addresses this issue. I also noticed that = there is >> a memory leak in the ahci code, which is addressed in the second patch= . >> >> Thanks, >> >> -Jason >> >> >> v2: >> fprintf -> DPRINTF (so can't be triggered by guest) >> 0 sglist fields >> >> >> Jason Baron (2): >> ahci: Fix ahci cdrom read corruptions for reads > 128k >> ahci: Fix sglist memleak in ahci_dma_rw_buf() >> >> dma-helpers.c | 1 + >> hw/ide/ahci.c | 44 +++++++++++++++++++++++++++++++++++++------- >> hw/ide/internal.h | 1 + >> 3 files changed, 39 insertions(+), 7 deletions(-) >> >=20 > Thanks, applied both to the block branch. Thanks, backported both to stable-0.15 (avoiding the new DMA helpers and GLib). Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg