From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE3EZ-0008LK-Ob for qemu-devel@nongnu.org; Tue, 18 Sep 2012 15:13:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TE3EY-0003D7-4c for qemu-devel@nongnu.org; Tue, 18 Sep 2012 15:13:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE3EX-0003Cr-RY for qemu-devel@nongnu.org; Tue, 18 Sep 2012 15:13:22 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8IJDKKV023885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 18 Sep 2012 15:13:20 -0400 Message-ID: <5058C7CC.1030004@redhat.com> Date: Tue, 18 Sep 2012 13:13:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <20120918160652.48fe5baa@doriath.home> In-Reply-To: <20120918160652.48fe5baa@doriath.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigA8CCD4ADE2A438E146B3597F" Subject: Re: [Qemu-devel] [PATCH] qapi: convert add_client List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA8CCD4ADE2A438E146B3597F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 09/18/2012 01:06 PM, Luiz Capitulino wrote: > Also fixes a few issues while there: >=20 > 1. The fd returned by monitor_get_fd() leaks in most error conditions > 2. monitor_get_fd() return value is not checked. Best case we get > an error that is not correctly reported, worse case one of the > functions using the fd (with value of -1) will explode > 3. A few error conditions aren't reported >=20 > Signed-off-by: Luiz Capitulino > --- > monitor.c | 39 --------------------------------------- > qapi-schema.json | 23 +++++++++++++++++++++++ > qmp-commands.hx | 5 +---- > qmp.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 68 insertions(+), 43 deletions(-) >=20 > { 'command': 'screendump', 'data': {'filename': 'str'} } > + > +## > +# @add_client Are these supposed to be sorted in any particular order? > +# > +# Allow client connections for VNC, Spice and socket based > +# character devices to be passed in to QEMU via SCM_RIGHTS. > +# > +# @protocol: protocol name. Valid names are "vnc", "spice" or the > +# name of a character device (eg. from -chardev id=3DXXXX) > +# > +# @fdname: file descriptor name passed via SCM_RIGHTS Misleading; isn't this really: file descriptor name previously passed via 'getfd' command since it is only 'getfd' that uses SCM_RIGHTS? > +# > +# skipauth: #optional whether to skip authentication > +# > +# tls: #optional whether to perform TLS Missing leading @ on two lines. > +# > +# Returns: nothing on success. > +# > +# Since: 0.14.0 If this were a new command for 1.3, I'd say to name it 'add-client'; but since QMP has already been exposing it and you are now just documenting it, you can't change the name. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigA8CCD4ADE2A438E146B3597F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQWMfNAAoJEKeha0olJ0NqkkEIAKsE3+5A3d+qDQHMrfczHOy4 zbzh4YBTq4znwDXncx+ABZVJiXW0mqIlKtx+NlHVCsmQeOVTNmlswB81tVVMwSU2 LZOFdUAHl6utvouGtMDcaTg94UDZealHehW5cexjfud+Gnd3tf5N9OxTj+zbbOOt CtEl9QexUJyxUkYrODqyfzVH96qmlXPEDrkTSLEEw6Z0TH1hBFm/ySyCRJV2ok4U XA6kIewLtGukcmlUDVmFOh7XtJmKYg27c+5EPycI1QHqQ7OjcvjRUYcRf1pACCDs Vqp9qegiQIus8E4/f+eSXaFgYLi8+bcdzGE/wU7kZ0VebHqMvUeuxDGQjjrdIxM= =eaVl -----END PGP SIGNATURE----- --------------enigA8CCD4ADE2A438E146B3597F--