From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TE4mN-0002tp-9m
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 16:52:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TE4mL-0005vr-N0
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 16:52:23 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34096 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TE4mL-0005vm-GJ
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 16:52:21 -0400
Message-ID: <5058DF02.5010903@suse.de>
Date: Tue, 18 Sep 2012 22:52:18 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1347224784-19472-1-git-send-email-rth@twiddle.net>
	<1347224784-19472-54-git-send-email-rth@twiddle.net>
In-Reply-To: <1347224784-19472-54-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 053/126] target-s390: Convert MVC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On 09/09/2012 11:05 PM, Richard Henderson wrote:
> The code that was in gen_op_mvc was a bit confused wrt what lengths
> it wanted to handle.  I also disbelieve that the inline memset is
> worthwhile.

I measured it back when I inlined it and I'm fairly sure I remember 
significant speedups from it. Compiling qemu with gprof enabled should 
be able to tell you :).


Alex