From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32939)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TE53N-0001MK-9N
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 17:09:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TE53K-0003HL-W4
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 17:09:57 -0400
Received: from cantor2.suse.de ([195.135.220.15]:35405 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TE53K-0003HH-PG
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 17:09:54 -0400
Message-ID: <5058E320.4030805@suse.de>
Date: Tue, 18 Sep 2012 23:09:52 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1347224784-19472-1-git-send-email-rth@twiddle.net>
	<5058E2B2.9000100@suse.de>
In-Reply-To: <5058E2B2.9000100@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 000/126] Rewrite s390x translator
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On 09/18/2012 11:08 PM, Alexander Graf wrote:
> On 09/09/2012 11:04 PM, Richard Henderson wrote:
>> As promised the other week.  I've cleaned up the patch set and
>> re-based it on Blueswirl's areg0 patch set.  For reference, the
>> entire patch set is available at
>>
>>    git://repo.or.cz/qemu/rth.git rth/s390-reorg-3
>>
>> Testing has mostly been on the gcc testsuite, where the execute
>> test failures are reduced to
>>
>> FAIL: gcc.dg/attr-ifunc-1.c execution test
>> FAIL: gcc.dg/attr-ifunc-3.c execution test
>> FAIL: gcc.dg/attr-ifunc-4.c execution test
>> FAIL: gcc.dg/attr-ifunc-5.c execution test
>> FAIL: gcc.dg/cdce1.c execution test
>> FAIL: gcc.dg/cleanup-11.c execution test
>> FAIL: gcc.dg/cleanup-9.c execution test
>> FAIL: gcc.dg/torture/pr41094.c  -O0  execution test
>> FAIL: gcc.dg/torture/tls/tls-test.c * execution test
>>
>> I'll probably start trying out the glibc testsuite next, as
>> that's quite likely to flush out remaining problems with the
>> fp support (both cdce1 and pr41094 are both failures in pow).
>>
>> I've also done some testing with -march={z10,z196}, but I
>> don't have those results handy atm.
>
> So I've had a look at the patch set. Overall it looks ok. I have to 
> admit that I found the old code a lot easier to understand and read. 
> But if you want to keep maintaining it the new way, I'm definitely ok 
> with that as well :).

Also, 102-126 are missing for me :).


Alex