From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33816)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TE7sT-0004Bp-2e
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 20:10:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TE7sR-0000tI-VW
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 20:10:52 -0400
Received: from mail-qa0-f45.google.com ([209.85.216.45]:49414)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TE7sR-0000t9-GF
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 20:10:51 -0400
Received: by qadc10 with SMTP id c10so2883579qad.4
	for <qemu-devel@nongnu.org>; Tue, 18 Sep 2012 17:10:50 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <50590D87.3030106@twiddle.net>
Date: Tue, 18 Sep 2012 17:10:47 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <alpine.LNX.2.00.1209182345370.1094@linmac>
In-Reply-To: <alpine.LNX.2.00.1209182345370.1094@linmac>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Shifts, ppc[64], xtensa
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org

On 09/18/2012 12:52 PM, malc wrote:
>      case INDEX_op_shl_i32:
>          if (const_args[2]) {
> +            if (args[2] > 31) {
> +                tcg_out_movi (s, TCG_TYPE_I32, 0, args[2]);
> +                tcg_out32 (s, SLW | SAB (args[1], args[0], 0));
> +            }

What's this bit for?

AFAIK all you should need are the added & 31 below.


r~