From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35293)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TEDHF-000878-0w
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 01:56:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TEDHE-00088Y-69
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 01:56:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12129)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TEDHD-00088M-TQ
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 01:56:48 -0400
Message-ID: <50595E98.9060505@redhat.com>
Date: Wed, 19 Sep 2012 07:56:40 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1347952634-12286-1-git-send-email-kraxel@redhat.com>
	<1347952634-12286-8-git-send-email-kraxel@redhat.com>
	<ye8lig73wgr.fsf@llama03.cs.au.dk>
In-Reply-To: <ye8lig73wgr.fsf@llama03.cs.au.dk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?U8O4cmVuIFNhbmRtYW5u?= <sandmann@cs.au.dk>
Cc: qemu-devel@nongnu.org

On 09/18/12 22:30, S=C3=B8ren Sandmann wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
>=20
>> +static pixman_image_t *pixman_from_displaystate(DisplayState *ds)
>> +{

>> +static pixman_image_t *pixman_from_framebuffer(void)
>> +{

> You may want to call pixman_format_supported_source/destination() here
> to ensure that the format in question is supported by pixman.

Ok.

>> +    pixman_region_fini(&dirty);
>> +    pixman_region_init(&dirty);
>>  }
>=20
> The fini()/init() here could be done with pixman_region_clear() which
> was introduced in 0.26.0.

Saw that, but rhel6 ships 0.18.something which hasn't this function yet.

cheers,
  Gerd