From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEE72-0000kD-IN for qemu-devel@nongnu.org; Wed, 19 Sep 2012 02:50:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEE6y-0000V0-EG for qemu-devel@nongnu.org; Wed, 19 Sep 2012 02:50:20 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:42450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEE6x-0000SL-Q8 for qemu-devel@nongnu.org; Wed, 19 Sep 2012 02:50:16 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Sep 2012 12:09:59 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8J6dvmv39649506 for ; Wed, 19 Sep 2012 12:09:57 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8JC9XiN003564 for ; Wed, 19 Sep 2012 17:39:33 +0530 Message-ID: <505968B6.10101@linux.vnet.ibm.com> Date: Wed, 19 Sep 2012 14:39:50 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1347958919-30380-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1347958919-30380-5-git-send-email-xiawenc@linux.vnet.ibm.com> <50584888.3020906@redhat.com> In-Reply-To: <50584888.3020906@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V3 4/5] libqblock test build system List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com 于 2012-9-18 18:10, Paolo Bonzini 写道: > Il 18/09/2012 11:01, Wenchao Xia ha scritto: >> Created a new directory in tests, make chekc-libqblock will build an >> executable binrary, make clean will delete it. >> >> Signed-off-by: Wenchao Xia >> --- >> .gitignore | 1 + >> Makefile | 1 + >> tests/Makefile | 3 +++ >> tests/libqblock/Makefile | 32 ++++++++++++++++++++++++++++++++ >> tests/libqblock/libqblock-test.c | 4 ++++ >> 5 files changed, 41 insertions(+), 0 deletions(-) >> create mode 100644 tests/libqblock/Makefile >> create mode 100644 tests/libqblock/libqblock-test.c >> >> diff --git a/.gitignore b/.gitignore >> index 824c0d2..eccb637 100644 >> --- a/.gitignore >> +++ b/.gitignore >> @@ -95,3 +95,4 @@ cscope.* >> tags >> TAGS >> *~ >> +tests/libqblock/*.bin >> diff --git a/Makefile b/Makefile >> index b0b9b8d..de8ea17 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -238,6 +238,7 @@ clean: >> rm -rf qapi-generated >> rm -rf qga/qapi-generated >> $(MAKE) -C tests/tcg clean >> + $(MAKE) -C tests/libqblock clean >> for d in $(ALL_SUBDIRS) $(QEMULIBS) libcacard libqblock; do \ >> if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \ >> rm -f $$d/qemu-options.def; \ >> diff --git a/tests/Makefile b/tests/Makefile >> index 26a67ce..69af1e2 100644 >> --- a/tests/Makefile >> +++ b/tests/Makefile >> @@ -148,4 +148,7 @@ check-unit: $(patsubst %,check-%, $(check-unit-y)) >> check-block: $(patsubst %,check-%, $(check-block-y)) >> check: check-unit check-qtest >> >> +check-libqblock: >> + $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C tests/libqblock V="$(V)" TARGET_DIR="$*/" check-libqblock,) > > Please just put everything in tests/Makefile. "make check" should run it > if LIBTOOL is available. > OK. >> +libqblock-test.bin: $(libqblock-test-objs) $(libqblock-la-path) >> + $(call quiet-command,$(LIBTOOL) --mode=link --quiet --tag=CC $(CC) -shared -rpath $(libdir) -o $@ $^," lt LINK $@") > > .bin looks so MS-DOS. :) > > Paolo > -- Best Regards Wenchao Xia