From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56880)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TEHQE-0005Wq-Q6
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 06:22:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TEHQD-0004Qm-SX
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 06:22:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25461)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TEHQD-0004Qi-Jv
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 06:22:21 -0400
Message-ID: <50599CD9.7040007@redhat.com>
Date: Wed, 19 Sep 2012 12:22:17 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1346079626-16386-1-git-send-email-pbonzini@redhat.com>
	<20120919101610.GA21916@redhat.com>
In-Reply-To: <20120919101610.GA21916@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 00/13] Embedded NBD server
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org

Il 19/09/2012 12:16, Daniel P. Berrange ha scritto:
>> > Three new commands are introduced at the QMP level
>> > 
>> >   { 'command': 'nbd-server-start',  'data': { 'addr': 'IPSocketAddress' } }
> It is probably desirable/required to also have a command where libvirt
> can pass in a pre-opened listening socket, since I think SELinux policy
> will not want to allow QEMU to create listening sockets itself.

Ok, I'll make it like this:

{ 'type': 'UnixSocketAddress',
  'data': {
    'path': 'str' } }

{ 'type': 'String',
  'data': {
    'str': 'str' } }

{'union': 'SocketAddress',
  'data': {
       'inet': 'IPSocketAddress',
       'unix': 'UnixSocketAddress',
       'fd': 'String',
   } }

Paolo