From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] qapi: convert add_client
Date: Wed, 19 Sep 2012 13:04:22 +0200 [thread overview]
Message-ID: <5059A6B6.7010001@redhat.com> (raw)
In-Reply-To: <20120918160652.48fe5baa@doriath.home>
Il 18/09/2012 21:06, Luiz Capitulino ha scritto:
> + fd = monitor_get_fd(cur_mon, fdname);
> + if (fd < 0) {
> + error_setg(errp, "file-description '%s' has not been found", fdname);
> + return;
> + }
Please change this to add an Error * argument to monitor_get_fd, and
change non-Error-friendly callers of monitor_get_fd to
monitor_handle_fd_param.
You can then reuse the error in monitor_handle_fd_param (there is
already QERR_FD_NOT_FOUND, by the way).
I'll post the patches later in my reviewed NBD series, please take them
from there and I'll rebase before my pull request.
Paolo
next prev parent reply other threads:[~2012-09-19 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 19:06 [Qemu-devel] [PATCH] qapi: convert add_client Luiz Capitulino
2012-09-18 19:13 ` Eric Blake
2012-09-18 19:20 ` Luiz Capitulino
2012-09-19 7:08 ` Markus Armbruster
2012-09-19 13:52 ` Luiz Capitulino
2012-09-19 11:04 ` Paolo Bonzini [this message]
2012-09-19 13:57 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5059A6B6.7010001@redhat.com \
--to=pbonzini@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).