From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TEI5b-0002Qn-SQ
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 07:05:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TEI51-00032E-61
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 07:05:07 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:33736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TEI50-000320-Ql
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 07:04:31 -0400
Received: by pbbrp12 with SMTP id rp12so2212997pbb.4
	for <qemu-devel@nongnu.org>; Wed, 19 Sep 2012 04:04:29 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5059A6B6.7010001@redhat.com>
Date: Wed, 19 Sep 2012 13:04:22 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20120918160652.48fe5baa@doriath.home>
In-Reply-To: <20120918160652.48fe5baa@doriath.home>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qapi: convert add_client
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Il 18/09/2012 21:06, Luiz Capitulino ha scritto:
> +    fd = monitor_get_fd(cur_mon, fdname);
> +    if (fd < 0) {
> +        error_setg(errp, "file-description '%s' has not been found", fdname);
> +        return;
> +    }

Please change this to add an Error * argument to monitor_get_fd, and
change non-Error-friendly callers of monitor_get_fd to
monitor_handle_fd_param.

You can then reuse the error in monitor_handle_fd_param (there is
already QERR_FD_NOT_FOUND, by the way).

I'll post the patches later in my reviewed NBD series, please take them
from there and I'll rebase before my pull request.

Paolo