From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53336)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TEMfN-00044c-EG
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 11:58:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TEMfJ-0004jn-Cg
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 11:58:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36934)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TEMfJ-0004jS-49
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 11:58:17 -0400
Message-ID: <5059EB94.9060409@redhat.com>
Date: Wed, 19 Sep 2012 17:58:12 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348065078-5139-1-git-send-email-pbonzini@redhat.com>
	<1348065078-5139-5-git-send-email-pbonzini@redhat.com>
	<CAFEAcA9iBtF9TeFCg+uHsm3D26cgxOD3eewRvrAaMFyq1N=XkA@mail.gmail.com>
In-Reply-To: <CAFEAcA9iBtF9TeFCg+uHsm3D26cgxOD3eewRvrAaMFyq1N=XkA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/12] qapi: add "unix" to the set of
 reserved words
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

Il 19/09/2012 17:46, Peter Maydell ha scritto:
> On 19 September 2012 15:31, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> It is #defined to 1.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  scripts/qapi.py | 4 +++-
>>  1 file modificato, 3 inserzioni(+). 1 rimozione(-)
>>
>> diff --git a/scripts/qapi.py b/scripts/qapi.py
>> index 057332e..afc5f32 100644
>> --- a/scripts/qapi.py
>> +++ b/scripts/qapi.py
>> @@ -156,7 +156,9 @@ def c_var(name, protect=True):
>>      # GCC http://gcc.gnu.org/onlinedocs/gcc-4.7.1/gcc/C-Extensions.html
>>      # excluding _.*
>>      gcc_words = set(['asm', 'typeof'])
>> -    if protect and (name in c89_words | c99_words | c11_words | gcc_words):
>> +    # namespace pollution:
>> +    polluted_words = set(['unix'])
>> +    if protect and (name in c89_words | c99_words | c11_words | gcc_words | polluted_words):
>>          return "q_" + name
>>      return name.replace('-', '_').lstrip("*")
>>
> 
> I can't help thinking this is fighting a losing battle, and we should just
> always prefix everything to avoid clashes.

That would be so ugly that it would be almost useless.  Plus there would
be a huge amount of code to convert.

Paolo