From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Peter Portante <pportant@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on timerfd
Date: Wed, 19 Sep 2012 18:12:29 +0200 [thread overview]
Message-ID: <5059EEED.7040405@redhat.com> (raw)
In-Reply-To: <5059ED2B.3090609@weilnetz.de>
Il 19/09/2012 18:04, Stefan Weil ha scritto:
> The win32 timer still works when these modifications were applied.
> What are they good for?
IIUC the Win32 did _not_ work (except on Wine) without these. Note I'm
talking about "-clock win32".
So these provide a hint that the problem with the Win32 timer is not in
the bowels of Windows, but only that it does not adjust the Windows
scheduler quantum. Wine does not need it because the Linux scheduler is
not as lame.
So if we just eliminated timers and used the g_poll timeout (what was
proposed upthread), Windows would work provided
timeBeginPeriod/timeEndPeriod are called correctly.
Paolo
next prev parent reply other threads:[~2012-09-19 16:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 20:37 [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on timerfd Anthony Liguori
2012-09-19 7:26 ` Paolo Bonzini
2012-09-19 7:44 ` Jan Kiszka
2012-09-19 8:39 ` Paolo Bonzini
2012-09-19 14:15 ` Peter Portante
2012-09-19 14:27 ` Jan Kiszka
2012-09-20 5:51 ` Peter Portante
2012-09-19 16:55 ` Avi Kivity
2012-09-19 17:13 ` Alon Ziv
2012-09-20 2:54 ` Anthony Liguori
2012-09-19 16:04 ` Stefan Weil
2012-09-19 16:12 ` Paolo Bonzini [this message]
2012-09-19 16:22 ` Stefan Weil
2012-09-19 14:20 ` Peter Portante
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5059EEED.7040405@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=pportant@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).