From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33276)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TEN31-0006Ml-1L
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 12:22:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TEN2z-0002l7-Ti
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 12:22:46 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:38140)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TEN2z-0002kj-NP
	for qemu-devel@nongnu.org; Wed, 19 Sep 2012 12:22:45 -0400
Message-ID: <5059F153.7000804@weilnetz.de>
Date: Wed, 19 Sep 2012 18:22:43 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1348000626-16129-1-git-send-email-aliguori@us.ibm.com>
	<5059738E.5070004@redhat.com> <5059ED2B.3090609@weilnetz.de>
	<5059EEED.7040405@redhat.com>
In-Reply-To: <5059EEED.7040405@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu-clock: add an alarm timer based on
	timerfd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Peter Portante <pportant@redhat.com>

Am 19.09.2012 18:12, schrieb Paolo Bonzini:
> Il 19/09/2012 18:04, Stefan Weil ha scritto:
>> The win32 timer still works when these modifications were applied.
>> What are they good for?
> IIUC the Win32 did _not_ work (except on Wine) without these.  Note I'm
> talking about "-clock win32".
>
> So these provide a hint that the problem with the Win32 timer is not in
> the bowels of Windows, but only that it does not adjust the Windows
> scheduler quantum.  Wine does not need it because the Linux scheduler is
> not as lame.
>
> So if we just eliminated timers and used the g_poll timeout (what was
> proposed upthread), Windows would work provided
> timeBeginPeriod/timeEndPeriod are called correctly.
>
> Paolo

I tested with -clock win32 (not the mm timer), and it worked on
Win7 (64 bit QEMU) with and without the modification.

Maybe I can run some more tests on 32 bit Windows (also with g_poll),
but don't expect results soon.

Stefan