* [Qemu-devel] [PATCH] s390x: fix -initrd in virtio machine
@ 2012-09-19 15:29 Alexander Graf
2012-09-19 16:31 ` Christian Borntraeger
2012-09-19 16:43 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Graf @ 2012-09-19 15:29 UTC (permalink / raw)
To: qemu-devel qemu-devel; +Cc: Christian Borntraeger, Richard Henderson
When using -initrd in the virtio machine, we need to indicate the initrd
start and size inside the kernel image. These parameters need to be stored
in native endianness.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
hw/s390-virtio.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c
index 47eed35..12ae612 100644
--- a/hw/s390-virtio.c
+++ b/hw/s390-virtio.c
@@ -284,8 +284,8 @@ static void s390_init(ram_addr_t my_ram_size,
}
/* we have to overwrite values in the kernel image, which are "rom" */
- memcpy(rom_ptr(INITRD_PARM_START), &initrd_offset, 8);
- memcpy(rom_ptr(INITRD_PARM_SIZE), &initrd_size, 8);
+ stq_p(rom_ptr(INITRD_PARM_START), initrd_offset);
+ stq_p(rom_ptr(INITRD_PARM_SIZE), initrd_size);
}
if (rom_ptr(KERN_PARM_AREA)) {
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] s390x: fix -initrd in virtio machine
2012-09-19 15:29 [Qemu-devel] [PATCH] s390x: fix -initrd in virtio machine Alexander Graf
@ 2012-09-19 16:31 ` Christian Borntraeger
2012-09-19 16:43 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Christian Borntraeger @ 2012-09-19 16:31 UTC (permalink / raw)
To: Alexander Graf; +Cc: qemu-devel qemu-devel, Richard Henderson
On 19/09/12 17:29, Alexander Graf wrote:
> When using -initrd in the virtio machine, we need to indicate the initrd
> start and size inside the kernel image. These parameters need to be stored
> in native endianness.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] s390x: fix -initrd in virtio machine
2012-09-19 15:29 [Qemu-devel] [PATCH] s390x: fix -initrd in virtio machine Alexander Graf
2012-09-19 16:31 ` Christian Borntraeger
@ 2012-09-19 16:43 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2012-09-19 16:43 UTC (permalink / raw)
To: Alexander Graf; +Cc: Christian Borntraeger, qemu-devel qemu-devel
On 09/19/2012 08:29 AM, Alexander Graf wrote:
> When using -initrd in the virtio machine, we need to indicate the initrd
> start and size inside the kernel image. These parameters need to be stored
> in native endianness.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
Tested-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-19 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-19 15:29 [Qemu-devel] [PATCH] s390x: fix -initrd in virtio machine Alexander Graf
2012-09-19 16:31 ` Christian Borntraeger
2012-09-19 16:43 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).