From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TENwx-00030X-Py for qemu-devel@nongnu.org; Wed, 19 Sep 2012 13:20:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TENwt-00030m-JY for qemu-devel@nongnu.org; Wed, 19 Sep 2012 13:20:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TENwt-0002zw-9i for qemu-devel@nongnu.org; Wed, 19 Sep 2012 13:20:31 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8JHKUGl030339 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 Sep 2012 13:20:30 -0400 Message-ID: <5059FEDC.6020900@redhat.com> Date: Wed, 19 Sep 2012 11:20:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348065078-5139-1-git-send-email-pbonzini@redhat.com> <1348065078-5139-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1348065078-5139-7-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigA285F1D077D782DDF6B29CDA" Subject: Re: [Qemu-devel] [PATCH 06/12] qapi: add socket address types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA285F1D077D782DDF6B29CDA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/19/2012 08:31 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qapi-schema.json | 53 ++++++++++++++++++++++++++++++++++++++++++++++++= +++++ > 1 file modificato, 53 inserzioni(+) >=20 > ## > +# @IPSocketAddress > +# > +# Captures the destination address of an IP socket Given the presence of @to, would this read better as: IP socket or socket range > +# > +# @host: host part of the address > +# > +# @port: port part of the address, or lowest port if @to is present > +# > +# @to: highest port to try > +# > +# @ipv4: whether to accept IPv4 addresses, default try both IPv4 and I= Pv6 > +# #optional Isn't the #optional supposed to occur first after the colon, as in: @ipv4: #optional whether to accept IPv4... > +# > +# @ipv6: whether to accept IPv6 addresses, default try both IPv4 and I= Pv6 > +# #optional > +# > +# Since 1.3 > +## > +{ 'type': 'IPSocketAddress', > + 'data': { > + 'host': 'str', > + 'port': 'str', > + '*to': 'uint16', Why is 'port' a string, but 'to' a uint16? Shouldn't they both be uint16= ? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigA285F1D077D782DDF6B29CDA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQWf7dAAoJEKeha0olJ0NqgMYH/AgfTJqeE8EI2mTN5nu+kB20 06MV1/aRnu5NE9MaFZ85LzHWBd3e2qQvaR2Ar3O97ebzbnLe7JUG9LpsHHDO52LI jIlOzXxleD3xB9VvR+ptyoVQBc362ZcHzDjBgzgBiE1GWiRR8vvxzDK0L/09Gq8u +uFgHSJDzVGQ0iQGVU3XQ2f7QTctSA7k1+DMv7h88ovd1XiJfFQJuTJAToV/hYJ7 RkoX06k0T3PcWuWJ9MzAqSrENhwbPKk8YxX/SGLNTojuuiTJYh5Za1y+Vx+p7792 4YgW2/oKWIMf29sXMt2L8OnsJ86jtatPnyz0RVeX6kZH6o8/1HpxWz1fZyC3aJk= =+0Nb -----END PGP SIGNATURE----- --------------enigA285F1D077D782DDF6B29CDA--