From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEOBc-0008Me-PO for qemu-devel@nongnu.org; Wed, 19 Sep 2012 13:35:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEOBY-0003Cl-Pb for qemu-devel@nongnu.org; Wed, 19 Sep 2012 13:35:44 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:35953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEOBY-0003CU-JW for qemu-devel@nongnu.org; Wed, 19 Sep 2012 13:35:40 -0400 Received: by pbbrp12 with SMTP id rp12so2972652pbb.4 for ; Wed, 19 Sep 2012 10:35:39 -0700 (PDT) Sender: Richard Henderson Message-ID: <505A011C.1020106@twiddle.net> Date: Wed, 19 Sep 2012 10:30:04 -0700 From: Richard Henderson MIME-Version: 1.0 References: <5059FA36.1080301@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Shifts, ppc[64], xtensa List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Max Filippov , qemu-devel@nongnu.org, Aurelien Jarno On 09/19/2012 10:11 AM, Peter Maydell wrote: > Can you elaborate? If we're emitting a native branch insn > and we're potentially changing the value in memory several > times during retranslate I would have thought it still applied. For brcond, we always apply the relocation before we ever try to execute the TB. For goto_tb, we expect the contents of the patch to contain valid insns from the start. We never apply a "null" relocation there. Perhaps this should be considerd a bug in cpu_gen_code, but that's where we are. I'm frankly surprised this ever works on ARM... r~