From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEONt-0003te-Qr for qemu-devel@nongnu.org; Wed, 19 Sep 2012 13:48:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEONo-0001sg-0t for qemu-devel@nongnu.org; Wed, 19 Sep 2012 13:48:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEONn-0001sa-O2 for qemu-devel@nongnu.org; Wed, 19 Sep 2012 13:48:19 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8JHmIJk027941 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 Sep 2012 13:48:19 -0400 Message-ID: <505A0561.8060107@redhat.com> Date: Wed, 19 Sep 2012 11:48:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348065078-5139-1-git-send-email-pbonzini@redhat.com> <1348065078-5139-15-git-send-email-pbonzini@redhat.com> In-Reply-To: <1348065078-5139-15-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig1F1463A1BB12756E78FD1873" Subject: Re: [Qemu-devel] [PATCH 14/12] qmp: add NBD server commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1F1463A1BB12756E78FD1873 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/19/2012 08:31 AM, Paolo Bonzini wrote: > Adding an NBD server inside QEMU is trivial, since all the logic is > in nbd.c and can be shared easily between qemu-nbd and QEMU itself. > The main difference is that qemu-nbd serves a single unnamed export, > while QEMU serves named exports. >=20 > Signed-off-by: Paolo Bonzini > --- > +## > +# @nbd-server-add: > +# > +# Export a device to QEMU's embedded NBD server. > +# > +# @device: Block device to be exported > +# > +# @writable: Whether clients should be able to write to the device via= the > +# NBD connection (default false). #optional Again, shouldn't #optional be first after the colon? > +# > +# Returns: error if the device is already marked for export. > +# > +# Since: 1.3.0 > +## > +{ 'command': 'nbd-server-add', 'data': {'device': 'str', '*writable': = 'bool'} } > + > +## > +# @nbd-server-stop: > +# > +# Stop QEMU's embedded NBD server, and unregister all devices previous= ly > +# added via @nbd-server-add. Do we need a way to unregister a single device, rather than having to stop the NBD server to unregister all devices? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig1F1463A1BB12756E78FD1873 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQWgVhAAoJEKeha0olJ0NqZwwIAJwFsAoeqmxe5TzKq6VPyyg9 UknDgAfHmWtHiPTfVmG1zSQDNrwRYD0aOIdZ5ZfN+fxdkICm1PcYjnCoHwQIFKGP LPCv1zntY/yDTIxQ5UucUSHHGS3KVF+/c/o32wwWUvOQaVw/teGTyu358yzJ3Coi zE4A4Jy4Dt6NVNqBpcXX2KzLCB7Io7eSOeek3BVU9/b6hrq8LlknmehP6V2ZyWz6 3ZN1U5ZD4gRgtZNAExO0DUdM01rL9w5f4MUFdVPKoD+nv2PInMOwsP2IG4XK6zqB wbtvEFZey4IjN80Kb2zWxC4jKSU4df3yTEoysTX61Lf5TDED5Ouye2JznPGbTLM= =w1GW -----END PGP SIGNATURE----- --------------enig1F1463A1BB12756E78FD1873--