From: Gerd Hoffmann <kraxel@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga
Date: Thu, 20 Sep 2012 07:43:17 +0200 [thread overview]
Message-ID: <505AACF5.6080703@redhat.com> (raw)
In-Reply-To: <CAAu8pHvr-GA7C3ky1kPiMC2XJornwP-1WR1Z-KHZsODyAA1p-g@mail.gmail.com>
Hi,
>> + vbe_ioport_write_index(&d->vga, 0, index);
>> + return vbe_ioport_read_data(&d->vga, 0);
>
> These functions are only available with CONFIG_BOCHS_VBE #defined, so
> this code should be conditional as well.
>
> But building without CONFIG_BOCHS_VBE is not very useful since it's
> used by the BIOS and there's no display output without it IIRC.
Well, text mode is still there, but no (by modern standards) useful
graphics modes, only standard vga ones (i.e. up to 800x600 @ 256 colors
or something like that).
I guess it is better to just remove CONFIG_BOCHS_VBE, /me goes prepare a
patch.
cheers,
Gerd
next prev parent reply other threads:[~2012-09-20 5:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 9:51 [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga Gerd Hoffmann
2012-09-18 10:32 ` Benjamin Herrenschmidt
2012-09-18 11:49 ` Gerd Hoffmann
2012-09-19 9:16 ` Avi Kivity
2012-09-19 11:35 ` Gerd Hoffmann
2012-09-19 12:13 ` Avi Kivity
2012-09-19 18:45 ` Blue Swirl
2012-09-20 5:43 ` Gerd Hoffmann [this message]
2012-09-22 12:12 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505AACF5.6080703@redhat.com \
--to=kraxel@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).