From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEZXo-0001R1-2Z for qemu-devel@nongnu.org; Thu, 20 Sep 2012 01:43:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEZXm-0002Fz-B0 for qemu-devel@nongnu.org; Thu, 20 Sep 2012 01:43:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEZXm-0002Fp-2H for qemu-devel@nongnu.org; Thu, 20 Sep 2012 01:43:22 -0400 Message-ID: <505AACF5.6080703@redhat.com> Date: Thu, 20 Sep 2012 07:43:17 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1347961897-28554-1-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Hi, >> + vbe_ioport_write_index(&d->vga, 0, index); >> + return vbe_ioport_read_data(&d->vga, 0); > > These functions are only available with CONFIG_BOCHS_VBE #defined, so > this code should be conditional as well. > > But building without CONFIG_BOCHS_VBE is not very useful since it's > used by the BIOS and there's no display output without it IIRC. Well, text mode is still there, but no (by modern standards) useful graphics modes, only standard vga ones (i.e. up to 800x600 @ 256 colors or something like that). I guess it is better to just remove CONFIG_BOCHS_VBE, /me goes prepare a patch. cheers, Gerd