From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54510)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TEaRx-0000Ts-Vh
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 02:41:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TEaRx-0004T5-1t
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 02:41:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34618)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TEaRw-0004Sx-Q5
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 02:41:24 -0400
Message-ID: <505ABA90.6070002@redhat.com>
Date: Thu, 20 Sep 2012 08:41:20 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1348062086-23490-1-git-send-email-mjt@msgid.tls.msk.ru>
In-Reply-To: <1348062086-23490-1-git-send-email-mjt@msgid.tls.msk.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid
 parameters handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org, Dunrong Huang <riegamaths@gmail.com>

On 09/19/12 15:41, Michael Tokarev wrote:
> This cleans up two additions of almost the same code in commits
> 511b13e2c9 and ccc2960d654.  While at it, make error paths
> consistent (always use 'break' instead of 'return').

Other way around: should be 'return' not 'break'.

cheers,
  Gerd