From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59787)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TEaiT-0005GU-3n
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 02:58:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TEaiS-0001Km-AE
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 02:58:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63109)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TEaiS-0001Ki-1t
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 02:58:28 -0400
Message-ID: <505ABE8F.1080001@redhat.com>
Date: Thu, 20 Sep 2012 08:58:23 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1347968442-8860-1-git-send-email-kwolf@redhat.com>
	<1347968442-8860-11-git-send-email-kwolf@redhat.com>
	<CAAu8pHursJtsf1X83-DKnqeq+d+0VvdwQV06LYJx1SUxCy=69g@mail.gmail.com>
In-Reply-To: <CAAu8pHursJtsf1X83-DKnqeq+d+0VvdwQV06LYJx1SUxCy=69g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 10/16] qcow2: Delay the COW
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

Am 19.09.2012 20:47, schrieb Blue Swirl:
> On Tue, Sep 18, 2012 at 11:40 AM, Kevin Wolf <kwolf@redhat.com> wrote:
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>>  block/qcow2-cluster.c |   29 +++++++++++++++++++++++++++++
>>  block/qcow2.c         |   31 ++++++++++++++++++++++++++++---
>>  block/qcow2.h         |   10 ++++++++++
>>  3 files changed, 67 insertions(+), 3 deletions(-)
>>
>> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
>> index a89d68d..0f50888 100644
>> --- a/block/qcow2-cluster.c
>> +++ b/block/qcow2-cluster.c
>> @@ -791,6 +791,34 @@ out:
>>      return i;
>>  }
>>
>> +struct KickL2Meta {
>> +    QEMUBH *bh;
>> +    QCowL2Meta *m;
>> +};
>> +
>> +static void kick_l2meta_bh(void *opaque)
>> +{
>> +    struct KickL2Meta *k = opaque;
>> +    QCowL2Meta *m = k->m;
>> +
>> +    qemu_bh_delete(k->bh);
>> +    free(k);
> 
> You use g_malloc() below.

Oops! Thanks, will fix.

Kevin