From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44492)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TEdA7-0003sv-2e
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 05:35:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TEdA1-0006FY-8G
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 05:35:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48675)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TEdA1-0006CJ-0N
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 05:35:05 -0400
Message-ID: <505AE340.9070306@redhat.com>
Date: Thu, 20 Sep 2012 11:34:56 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <20120917152149.GB6879@in.ibm.com>
	<20120917152620.GG6879@in.ibm.com> <50587ED6.9040504@redhat.com>
	<20120920064114.GD5873@in.ibm.com>
	<505ACB62.7020409@redhat.com> <505AD1D1.70604@redhat.com>
	<20120920091214.GE5873@in.ibm.com>
In-Reply-To: <20120920091214.GE5873@in.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU
	block backend.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: bharata@linux.vnet.ibm.com
Cc: Anthony Liguori <aliguori@us.ibm.com>, Anand Avati <aavati@redhat.com>, Vijay Bellur <vbellur@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Amar Tumballi <amarts@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 20.09.2012 11:12, schrieb Bharata B Rao:
> On Thu, Sep 20, 2012 at 10:20:33AM +0200, Paolo Bonzini wrote:
>> Il 20/09/2012 09:53, Paolo Bonzini ha scritto:
>>>>>> Would look a bit nicer with strstart() form cutils.c instead of strncmp().
>>>>> strstart() works with const char pointers, but I have char pointers here
>>>>> which I need to modify.
>>> You can pass a char* to a function that accepts const char*.  In your
>>> case, the last argument to strstart would be NULL.
>>
>> As you pointed out on IRC, you meant the last argument.  I don't think
>> it would be a problem to cast that from char ** to const char **.
>>
>> Perhaps it would be cleaner to make qemu_gluster_parseuri and
>> parse_gluster_spec accept a const char *.  You can replace strtok_r +
>> g_strdup with strspn/strcspn followed by g_strndup.
> 
> I feel the current approach of using the combination of strncmp, strtok_r
> and g_strdup should be good enough.

Now that Paolo agreed that there wouldn't be a problem with casting,
let's use strstart with a cast to (const char**) for the third
parameter. Using strtok_r is okay with me.

Kevin