From: Orit Wasserman <owasserm@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, akong@redhat.com,
mst@redhat.com, quintela@redhat.com, mdroth@linux.vnet.ibm.com,
qemu-devel@nongnu.org, pbonzini@redhat.com,
lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect
Date: Thu, 20 Sep 2012 17:56:37 +0300 [thread overview]
Message-ID: <505B2EA5.7010900@redhat.com> (raw)
In-Reply-To: <878vc43lug.fsf@blackfin.pond.sub.org>
On 09/20/2012 03:44 PM, Markus Armbruster wrote:
> Orit Wasserman <owasserm@redhat.com> writes:
>
>> No need to add non blocking parameters to the blocking inet_connect
>> add block parameter for inet_connect_opts instead of using QemuOpt "block".
>
> I believe option "block" in qemu-sockets.c's dummy_opts is now unused,
> and should be dropped. It was added in commit a6ba35b3.
>
You are right , I will remove it.
Orit
next prev parent reply other threads:[~2012-09-20 14:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 18:58 [Qemu-devel] [PATCH v3 0/3] nonblocking connect address handling cleanup Orit Wasserman
2012-09-13 18:58 ` [Qemu-devel] [PATCH v3 1/3] Refactor inet_connect_opts function Orit Wasserman
2012-09-14 8:58 ` Juan Quintela
2012-09-19 8:33 ` Amos Kong
2012-09-20 2:33 ` Amos Kong
2012-09-20 11:22 ` Orit Wasserman
2012-09-20 12:38 ` Markus Armbruster
2012-09-20 11:21 ` Orit Wasserman
2012-09-13 18:58 ` [Qemu-devel] [PATCH v3 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect Orit Wasserman
2012-09-14 9:07 ` Juan Quintela
2012-09-20 12:44 ` Markus Armbruster
2012-09-20 14:56 ` Orit Wasserman [this message]
2012-09-13 18:58 ` [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect Orit Wasserman
2012-09-14 9:17 ` Juan Quintela
2012-09-19 8:31 ` Amos Kong
2012-09-20 11:20 ` Orit Wasserman
2012-09-20 15:16 ` Amos Kong
2012-09-23 6:34 ` Orit Wasserman
2012-09-24 9:48 ` Amos Kong
2012-09-24 10:40 ` Orit Wasserman
2012-09-24 11:41 ` Amos Kong
2012-09-20 6:03 ` Michael S. Tsirkin
2012-09-20 8:57 ` Orit Wasserman
2012-09-20 9:37 ` Michael S. Tsirkin
2012-09-20 10:00 ` Orit Wasserman
2012-09-20 13:14 ` Markus Armbruster
2012-09-20 14:53 ` Orit Wasserman
2012-09-21 8:03 ` Markus Armbruster
2012-09-23 7:31 ` Orit Wasserman
2012-09-20 13:19 ` [Qemu-devel] [PATCH v3 0/3] nonblocking connect address handling cleanup Markus Armbruster
2012-09-20 14:55 ` Orit Wasserman
2012-09-20 15:12 ` Paolo Bonzini
2012-09-20 15:19 ` Michael S. Tsirkin
2012-09-20 15:15 ` Michael S. Tsirkin
2012-09-21 8:03 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B2EA5.7010900@redhat.com \
--to=owasserm@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).