From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEiBL-0001HD-3w for qemu-devel@nongnu.org; Thu, 20 Sep 2012 10:56:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEiBB-0003rh-1F for qemu-devel@nongnu.org; Thu, 20 Sep 2012 10:56:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEiBA-0003rQ-PM for qemu-devel@nongnu.org; Thu, 20 Sep 2012 10:56:36 -0400 Message-ID: <505B2EA5.7010900@redhat.com> Date: Thu, 20 Sep 2012 17:56:37 +0300 From: Orit Wasserman MIME-Version: 1.0 References: <1347562697-15411-1-git-send-email-owasserm@redhat.com> <1347562697-15411-3-git-send-email-owasserm@redhat.com> <878vc43lug.fsf@blackfin.pond.sub.org> In-Reply-To: <878vc43lug.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, aliguori@us.ibm.com, akong@redhat.com, mst@redhat.com, quintela@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com On 09/20/2012 03:44 PM, Markus Armbruster wrote: > Orit Wasserman writes: > >> No need to add non blocking parameters to the blocking inet_connect >> add block parameter for inet_connect_opts instead of using QemuOpt "block". > > I believe option "block" in qemu-sockets.c's dummy_opts is now unused, > and should be dropped. It was added in commit a6ba35b3. > You are right , I will remove it. Orit