From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEltv-0000ZF-Ed for qemu-devel@nongnu.org; Thu, 20 Sep 2012 14:55:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEltu-0001kK-8r for qemu-devel@nongnu.org; Thu, 20 Sep 2012 14:55:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEltt-0001i2-SR for qemu-devel@nongnu.org; Thu, 20 Sep 2012 14:55:02 -0400 Message-ID: <505B6680.2000609@redhat.com> Date: Thu, 20 Sep 2012 14:54:56 -0400 From: Rik van Riel MIME-Version: 1.0 References: <1348149875-29678-1-git-send-email-mgorman@suse.de> <1348149875-29678-5-git-send-email-mgorman@suse.de> In-Reply-To: <1348149875-29678-5-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] Revert "mm: have order > 0 compaction start off where it left" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mel Gorman Cc: Richard Davies , KVM , QEMU-devel , LKML , Linux-MM , Avi Kivity , Shaohua Li On 09/20/2012 10:04 AM, Mel Gorman wrote: > This reverts commit 7db8889a (mm: have order > 0 compaction start off > where it left) and commit de74f1cc (mm: have order > 0 compaction start > near a pageblock with free pages). These patches were a good idea and > tests confirmed that they massively reduced the amount of scanning but > the implementation is complex and tricky to understand. A later patch > will cache what pageblocks should be skipped and reimplements the > concept of compact_cached_free_pfn on top for both migration and > free scanners. > > Signed-off-by: Mel Gorman Sure, it makes your next patches easier... Acked-by: Rik van Riel