From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEnUb-0005tI-9L for qemu-devel@nongnu.org; Thu, 20 Sep 2012 16:37:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEnUa-0005W5-89 for qemu-devel@nongnu.org; Thu, 20 Sep 2012 16:37:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEnUZ-0005W0-W6 for qemu-devel@nongnu.org; Thu, 20 Sep 2012 16:37:00 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8KKaxxv019336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Sep 2012 16:36:59 -0400 Message-ID: <505B7E69.50502@redhat.com> Date: Thu, 20 Sep 2012 14:36:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348165081-28292-1-git-send-email-lcapitulino@redhat.com> <1348165081-28292-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1348165081-28292-3-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig42F58000F77D49827A83915D" Subject: Re: [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: akong@redhat.com, qemu-devel@nongnu.org, avi@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig42F58000F77D49827A83915D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/20/2012 12:18 PM, Luiz Capitulino wrote: > Before the qapi conversion, the sendkey command could be used to > send key codes in hex directly to the guest. This doesn't work > with the current implemention, as it will only send to the guest > QKeyCode values. That's a regression. >=20 > This commit fixes the problem by adding hex value support down > the QMP interface, qmp_send_key(). >=20 > In more detail, this commit: >=20 > 1. Adds the KeyValue union. This can represent an hex value or > a QKeyCode value >=20 > 2. *Changes* the QMP send-key command to take an KeyValue argument > instead of a QKeyCode one. >=20 > 3. Adapt hmp_send_key() to the QMP interface changes >=20 > Item 2 is an incompatible change, but as we're development phase > (and this command has been merged a few weeks ago) this shouldn't be > a problem. Concur - send-key is listed as 'Since: 1.3.0', so we are free to change it however we see fit. Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig42F58000F77D49827A83915D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQW35qAAoJEKeha0olJ0NqLLUH/iTnWos+Y1thZUMsJL4oRUej z4EcDcC2G1O6xDH+F7+VUBCPK+W02xBPgfo9yt8GX/mdAVbhMGKwIW14gy7xAaeZ AmTBI9jDhKchWNNHrRDCdfU9zScHQu00raRCXUFqKfvjCIlAbsUcajqJ9kxkyYWu 3CHvpl+nQfQ7/x24mK0UEB8VBn70bao8LP0Jg2dOwWG9IdgNtipEc+AwWnnFULj/ McplvlIpkKDPH2sbU23jqZzg/3qLdDvU2zRbSXZAInz2W3vfjoyLm9iI+IngeVvI Pc7zsPB/FhowF44H2AIxnjFzDpvIbtAqqGWdoSypPp3dLgxd3DRHUob4uj85K/Y= =Dsk0 -----END PGP SIGNATURE----- --------------enig42F58000F77D49827A83915D--