From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59229)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TEpWl-0006vM-SU
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 18:47:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TEpWk-00012t-Vr
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 18:47:23 -0400
Received: from mail-pa0-f45.google.com ([209.85.220.45]:54915)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TEpWk-00012o-PI
	for qemu-devel@nongnu.org; Thu, 20 Sep 2012 18:47:22 -0400
Received: by padfb10 with SMTP id fb10so254323pad.4
	for <qemu-devel@nongnu.org>; Thu, 20 Sep 2012 15:47:21 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <505B9CF7.2020000@twiddle.net>
Date: Thu, 20 Sep 2012 15:47:19 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1347978240-20260-1-git-send-email-rth@twiddle.net>
	<1347978240-20260-2-git-send-email-rth@twiddle.net>
	<20120920220641.GD4457@ohm.aurel32.net>
In-Reply-To: <20120920220641.GD4457@ohm.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/5] tcg: Introduce movcond
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 09/20/2012 03:06 PM, Aurelien Jarno wrote:
>> > +    if (TCG_TARGET_HAS_movcond_i64) {
>> > +        tcg_gen_op6i_i64(INDEX_op_movcond_i64, ret, c1, c2, v1, v2, cond);
>> > +        return;
> Minor nitpick: there is useless return here, and it's not present for
> movcond_i32.
> 

Ah, right.  I started to add a case for implementing movcond_i64
with movcond_i32, but didn't finish.


r~