From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TExOp-00076v-FZ for qemu-devel@nongnu.org; Fri, 21 Sep 2012 03:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TExOh-0005fQ-M0 for qemu-devel@nongnu.org; Fri, 21 Sep 2012 03:11:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TExOh-0005fJ-Dw for qemu-devel@nongnu.org; Fri, 21 Sep 2012 03:11:35 -0400 Message-ID: <505C131A.2030501@redhat.com> Date: Fri, 21 Sep 2012 09:11:22 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <20120920232022.GA13110@tuon.disenchant.local> In-Reply-To: <20120920232022.GA13110@tuon.disenchant.local> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] blockdev: preserve readonly and snapshot states across media changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Shanahan Cc: libvir-list@redhat.com, Michael Tokarev , Markus Armbruster , qemu-devel@nongnu.org Am 21.09.2012 01:20, schrieb Kevin Shanahan: > If readonly=on is given at device creation time, the ->readonly flag > needs to be set in the block driver state for this device so that > readonly-ness is preserved across media changes (qmp change command). > Similarly, to preserve the snapshot property requires ->open_flags to > be correct. > > Signed-off-by: Kevin Shanahan Thanks, applied to the block branch. Kevin