From: Jan Kiszka <jan.kiszka@siemens.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller
Date: Fri, 21 Sep 2012 13:49:01 +0200 [thread overview]
Message-ID: <505C542D.1090004@siemens.com> (raw)
In-Reply-To: <505841CA.9020004@redhat.com>
On 2012-09-18 11:41, Hans de Goede wrote:
> Hi,
>
> On 09/17/2012 06:22 PM, Jan Kiszka wrote:
>>> If that does not work, add the debug parameter to the usb-redir device,
>>> set it
>>> to 4, collect logs of trying to redirect the device and send me the logs
>>> please, ie:
>>> -device usb-redir,chardev=usbredirchardev1,id=usbredirdev1,debug=4
>>>
>>> Also be aware that usb-redir relies on chardev flowcontrol working,
>>> which it does not upstream! See for example here for the chardev flow
>>> control patch set which RHEL / Fedora carry:
>>> http://cgit.freedesktop.org/~jwrdegoede/qemu/log/?h=qemu-kvm-1.2-usbredir&ofs=50
>>>
>>>
>>> And then the first 13 patches after: "Merge tag 'v1.2.0'"
>>>
>>> Oh, and also, if you're running qemu git master, make sure you've:
>>> http://cgit.freedesktop.org/~jwrdegoede/qemu/commit/?id=81e34f5973d8d6a1ef998a50c4a4bf66abb3b56b
>>>
>>
>> I used qemu-kvm-1.2-usbredir^ (the last commit is apparently broken -
>> copy&paste bug?).
>
> Yeah, that has been fixed now.
>
>> I'm getting this right after typing cat /dev/ACM0 in
>> the guest. It's an endless stream, and so is the output in the guest
>> although there should be nothing to dump (that's the proper behaviour on
>> the host).
>
> Hmm, can you try commenting out line 1608 of hw/usb/redirect.c:
> usb_ep->pipeline = true;
>
> And see if that helps. If it does not help, please bump the debug level to 5
> (this will also make it log packet contents), and then generate another log, and
> then it is time to dive into the ACM protocol to see what is happening...
As it looks like now, I was just using the wrong test on the guest side.
Retried this morning briefly with a terminal program, and it was all
fine, even when forwarding from host-ehci to guest-uhci (with my broken
patch), even when using current QEMU git head. Sorry for the noise
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-09-21 11:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 16:27 [Qemu-devel] [PATCH] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller Jan Kiszka
2012-09-17 9:08 ` Hans de Goede
2012-09-17 9:18 ` Jan Kiszka
2012-09-17 14:24 ` Hans de Goede
2012-09-17 16:22 ` Jan Kiszka
2012-09-18 9:41 ` Hans de Goede
2012-09-21 11:49 ` Jan Kiszka [this message]
2012-09-21 12:21 ` Hans de Goede
2012-09-21 12:25 ` Jan Kiszka
2012-09-18 21:18 ` Anthony Liguori
2012-09-19 9:20 ` Hans de Goede
2012-09-22 9:29 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2012-10-08 17:36 ` Jan Kiszka
2012-10-08 23:05 ` [Qemu-devel] [v2] " Hans de Goede
2012-10-09 8:38 ` Hans de Goede
2012-10-09 8:40 ` Gerd Hoffmann
2012-10-09 10:05 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505C542D.1090004@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=hdegoede@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).