From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF24s-0004x4-Mu for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF24o-0006Jq-J8 for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:11:26 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:63932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF24o-0006Jm-Bn for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:11:22 -0400 Received: by pbbrp12 with SMTP id rp12so7547628pbb.4 for ; Fri, 21 Sep 2012 05:11:21 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <505C5961.7080508@redhat.com> Date: Fri, 21 Sep 2012 14:11:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348217255-22441-1-git-send-email-quintela@redhat.com> <1348217255-22441-2-git-send-email-quintela@redhat.com> In-Reply-To: <1348217255-22441-2-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/41] buffered_file: g_realloc() can't fail List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org Il 21/09/2012 10:46, Juan Quintela ha scritto: > Signed-off-by: Juan Quintela > --- > buffered_file.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/buffered_file.c b/buffered_file.c > index f170aa0..4148abb 100644 > --- a/buffered_file.c > +++ b/buffered_file.c > @@ -50,20 +50,12 @@ static void buffered_append(QEMUFileBuffered *s, > const uint8_t *buf, size_t size) > { > if (size > (s->buffer_capacity - s->buffer_size)) { > - void *tmp; > - > DPRINTF("increasing buffer capacity from %zu by %zu\n", > s->buffer_capacity, size + 1024); > > s->buffer_capacity += size + 1024; > > - tmp = g_realloc(s->buffer, s->buffer_capacity); > - if (tmp == NULL) { > - fprintf(stderr, "qemu file buffer expansion failed\n"); > - exit(1); > - } > - > - s->buffer = tmp; > + s->buffer = g_realloc(s->buffer, s->buffer_capacity); > } > > memcpy(s->buffer + s->buffer_size, buf, size); > Reviewed-by: Paolo Bonzini Paolo