From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.
Date: Fri, 21 Sep 2012 14:28:34 +0200 [thread overview]
Message-ID: <505C5D72.8050005@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1209191904320.29232@kaball.uk.xensource.com>
Hi,
>> + case FB_ACQ_REQ:
>> + fbdev_switch_acquire();
>> + redraw_screen++;
>
> Rather than introducing redraw_screen, I would just call vga_hw_invalidate
> instead here. It is always a win if we can avoid to introduce one more
> state machine.
Wouldn't that make the vga emulation do additional work which is simply
not needed?
cheers,
Gerd
next prev parent reply other threads:[~2012-09-21 12:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 11:15 [Qemu-devel] [PATCH v4 0/9] linux framebuffer display driver Gerd Hoffmann
2012-09-19 11:15 ` [Qemu-devel] [PATCH 1/9] QLIST-ify display change listeners Gerd Hoffmann
2012-09-19 11:15 ` [Qemu-devel] [PATCH 2/9] add unregister_displaychangelistener Gerd Hoffmann
2012-09-19 11:15 ` [Qemu-devel] [PATCH 3/9] move set_mouse + cursor_define callbacks Gerd Hoffmann
2012-09-19 11:15 ` [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver Gerd Hoffmann
2012-09-19 18:09 ` Stefano Stabellini
2012-09-21 12:28 ` Gerd Hoffmann [this message]
2012-09-24 11:06 ` Stefano Stabellini
2012-09-24 13:09 ` Gerd Hoffmann
2012-09-19 11:15 ` [Qemu-devel] [PATCH 5/9] fbdev: add monitor command to enable/disable Gerd Hoffmann
2012-09-19 11:15 ` [Qemu-devel] [PATCH 6/9] fbdev: make configurable at compile time Gerd Hoffmann
2012-09-19 11:15 ` [Qemu-devel] [PATCH 7/9] fbdev: move to pixman Gerd Hoffmann
2012-09-19 18:10 ` Stefano Stabellini
2012-09-20 6:16 ` Gerd Hoffmann
2012-09-20 11:33 ` Stefano Stabellini
2012-09-20 13:51 ` Gerd Hoffmann
2012-09-20 15:20 ` Stefano Stabellini
2012-09-20 15:27 ` Gerd Hoffmann
2012-09-20 15:28 ` Stefano Stabellini
2012-09-20 15:33 ` Stefano Stabellini
2012-09-21 5:40 ` Gerd Hoffmann
2012-09-21 10:48 ` Stefano Stabellini
2012-09-19 11:15 ` [Qemu-devel] [PATCH 8/9] fbdev: add mouse pointer support Gerd Hoffmann
2012-09-19 11:15 ` [Qemu-devel] [PATCH 9/9] fbdev: add display scaling support Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2012-09-18 7:17 [Qemu-devel] [PULL 0/9] linux framebuffer display driver Gerd Hoffmann
2012-09-18 7:17 ` [Qemu-devel] [PATCH 4/9] fbdev: add " Gerd Hoffmann
2012-09-18 15:01 ` Stefano Stabellini
2012-09-19 5:19 ` Gerd Hoffmann
2012-09-19 18:37 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505C5D72.8050005@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).