From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60842)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TF2Lb-00075I-VO
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:28:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TF2La-0003eV-2t
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:28:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56324)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TF2LZ-0003eG-R6
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:28:42 -0400
Message-ID: <505C5D72.8050005@redhat.com>
Date: Fri, 21 Sep 2012 14:28:34 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1348053341-29212-1-git-send-email-kraxel@redhat.com>
	<1348053341-29212-5-git-send-email-kraxel@redhat.com>
	<alpine.DEB.2.02.1209191904320.29232@kaball.uk.xensource.com>
In-Reply-To: <alpine.DEB.2.02.1209191904320.29232@kaball.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display
 driver.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

  Hi,

>> +    case FB_ACQ_REQ:
>> +        fbdev_switch_acquire();
>> +        redraw_screen++;
> 
> Rather than introducing redraw_screen, I would just call vga_hw_invalidate
> instead here. It is always a win if we can avoid to introduce one more
> state machine.

Wouldn't that make the vga emulation do additional work which is simply
not needed?

cheers,
  Gerd