From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36075)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2Wk-0005st-Jq
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:40:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2Wb-0007bG-2f
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:40:14 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:62391)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2WZ-0007V5-Oe
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:40:05 -0400
Received: by pbbrp12 with SMTP id rp12so7596540pbb.4
	for <qemu-devel@nongnu.org>; Fri, 21 Sep 2012 05:40:01 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <505C601B.5010209@redhat.com>
Date: Fri, 21 Sep 2012 14:39:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348217255-22441-1-git-send-email-quintela@redhat.com>
	<1348217255-22441-25-git-send-email-quintela@redhat.com>
In-Reply-To: <1348217255-22441-25-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 24/41] buffered_file: callers of
 buffered_flush() already check for errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

Il 21/09/2012 10:47, Juan Quintela ha scritto:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  buffered_file.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/buffered_file.c b/buffered_file.c
> index 43e68b6..747d672 100644
> --- a/buffered_file.c
> +++ b/buffered_file.c
> @@ -61,13 +61,6 @@ static void buffered_append(QEMUFileBuffered *s,
>  static void buffered_flush(QEMUFileBuffered *s)
>  {
>      size_t offset = 0;
> -    int error;
> -
> -    error = qemu_file_get_error(s->file);
> -    if (error != 0) {
> -        DPRINTF("flush when error, bailing: %s\n", strerror(-error));
> -        return;
> -    }
> 
>      DPRINTF("flushing %zu byte(s) of data\n", s->buffer_size);
> 

Right, they do so _before_ checking buffered_flush which matches the
code you are removing here.

Perhaps an assertion would be better, but still:

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>