From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF2cH-0002qL-Oq for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:46:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF2cB-0001lB-Ux for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:45:57 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:56212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF2cB-0001kv-PN for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:45:51 -0400 Received: by pbbrp12 with SMTP id rp12so7606576pbb.4 for ; Fri, 21 Sep 2012 05:45:51 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <505C617A.1080107@redhat.com> Date: Fri, 21 Sep 2012 14:45:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348217255-22441-1-git-send-email-quintela@redhat.com> <1348217255-22441-29-git-send-email-quintela@redhat.com> In-Reply-To: <1348217255-22441-29-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 28/41] virtio-net: use qemu_get_buffer() in a temp buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org Il 21/09/2012 10:47, Juan Quintela ha scritto: > qemu_fseek() is known to be wrong. Would be removed on the next > commit. This code should never been used (value has been > MAC_TABLE_ENTRIES since 2009). > > Signed-off-by: Juan Quintela > --- > hw/virtio-net.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio-net.c b/hw/virtio-net.c > index 6490743..e8c43af 100644 > --- a/hw/virtio-net.c > +++ b/hw/virtio-net.c > @@ -921,7 +921,9 @@ static int virtio_net_load(QEMUFile *f, void *opaque, int version_id) > qemu_get_buffer(f, n->mac_table.macs, > n->mac_table.in_use * ETH_ALEN); > } else if (n->mac_table.in_use) { > - qemu_fseek(f, n->mac_table.in_use * ETH_ALEN, SEEK_CUR); > + uint8_t *buf = g_malloc0(n->mac_table.in_use); > + qemu_get_buffer(f, buf, n->mac_table.in_use * ETH_ALEN); > + g_free(buf); > n->mac_table.multi_overflow = n->mac_table.uni_overflow = 1; > n->mac_table.in_use = 0; > } > Reviewed-by: Paolo Bonzini