From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56532)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2es-0005oc-I2
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:48:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2eo-0002ca-Fm
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:48:38 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:63309)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2eo-0002aT-9K
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:48:34 -0400
Received: by mail-pb0-f45.google.com with SMTP id rp12so7610819pbb.4
	for <qemu-devel@nongnu.org>; Fri, 21 Sep 2012 05:48:33 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <505C621C.4070903@redhat.com>
Date: Fri, 21 Sep 2012 14:48:28 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348217255-22441-1-git-send-email-quintela@redhat.com>
	<1348217255-22441-33-git-send-email-quintela@redhat.com>
In-Reply-To: <1348217255-22441-33-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 32/41] savevm: unexport qemu_ftell()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

Il 21/09/2012 10:47, Juan Quintela ha scritto:
> It was unused out of savevm.c.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  qemu-file.h | 3 ---
>  savevm.c    | 2 +-
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/qemu-file.h b/qemu-file.h
> index 7fe7274..289849a 100644
> --- a/qemu-file.h
> +++ b/qemu-file.h
> @@ -230,7 +230,4 @@ static inline void qemu_get_sbe64s(QEMUFile *f, int64_t *pv)
>  {
>      qemu_get_be64s(f, (uint64_t *)pv);
>  }
> -
> -int64_t qemu_ftell(QEMUFile *f);
> -
>  #endif
> diff --git a/savevm.c b/savevm.c
> index 8efa7cc..8ddb9d5 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -664,7 +664,7 @@ int qemu_get_byte(QEMUFile *f)
>      return result;
>  }
> 
> -int64_t qemu_ftell(QEMUFile *f)
> +static int64_t qemu_ftell(QEMUFile *f)
>  {
>      return f->buf_offset - f->buf_size + f->buf_index;
>  }
> 

static inline?

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>