From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59654)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2gY-00004x-Eu
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:50:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2gR-0003G5-Jj
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:50:22 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:49135)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2gR-0003Fc-Dd
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:50:15 -0400
Received: by pbbrp12 with SMTP id rp12so7614303pbb.4
	for <qemu-devel@nongnu.org>; Fri, 21 Sep 2012 05:50:14 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <505C6281.8080803@redhat.com>
Date: Fri, 21 Sep 2012 14:50:09 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348217255-22441-1-git-send-email-quintela@redhat.com>
	<1348217255-22441-36-git-send-email-quintela@redhat.com>
In-Reply-To: <1348217255-22441-36-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 35/41] buffered_file: buffered_put_buffer()
 don't need to set last_error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

Il 21/09/2012 10:47, Juan Quintela ha scritto:
> Callers on savevm.c:qemu_fflush() will set it.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  buffered_file.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/buffered_file.c b/buffered_file.c
> index 6d9a50b..318d0f0 100644
> --- a/buffered_file.c
> +++ b/buffered_file.c
> @@ -120,8 +120,6 @@ static int buffered_put_buffer(void *opaque, const uint8_t *buf, int64_t pos, in
>      error = buffered_flush(s);
>      if (error < 0) {
>          DPRINTF("buffered flush error. bailing: %s\n", strerror(-error));
> -        qemu_file_set_error(s->file, error);
> -
>          return error;
>      }
> 

Yo dawg, I heard you like buffers so I put a buffer in your buffered
file so you buffer while the file buffers.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>