From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47449)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2kw-0005mL-Pg
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:55:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2kn-0004nL-B0
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:54:54 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:43771)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF2kn-0004nA-42
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 08:54:45 -0400
Received: by pbbrp12 with SMTP id rp12so7621939pbb.4
	for <qemu-devel@nongnu.org>; Fri, 21 Sep 2012 05:54:44 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <505C638F.7050306@redhat.com>
Date: Fri, 21 Sep 2012 14:54:39 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348217255-22441-1-git-send-email-quintela@redhat.com>
	<1348217255-22441-42-git-send-email-quintela@redhat.com>
In-Reply-To: <1348217255-22441-42-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 41/41] cpus: create qemu_cpu_is_vcpu()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

Il 21/09/2012 10:47, Juan Quintela ha scritto:
> Old code used !io_thread to know if a thread was an vcpu or not.  That
> fails when we introduce the iothread.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  cpus.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/cpus.c b/cpus.c
> index e476a3c..1b7061a 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -902,6 +902,11 @@ int qemu_cpu_is_self(void *_env)
>      return qemu_thread_is_self(cpu->thread);
>  }
> 
> +static bool qemu_cpu_is_vcpu(void)
> +{
> +    return cpu_single_env && qemu_cpu_is_self(&cpu_single_env);

Should be "cpu_single_env && qemu_cpu_is_self(&cpu_single_env)".

Please named the function qemu_in_vcpu_thread.

Paolo

> +}
> +
>  void qemu_mutex_lock_iothread(void)
>  {
>      if (!tcg_enabled()) {
> @@ -947,7 +952,7 @@ void pause_all_vcpus(void)
>          penv = penv->next_cpu;
>      }
> 
> -    if (!qemu_thread_is_self(&io_thread)) {
> +    if (qemu_cpu_is_vcpu()) {
>          cpu_stop_current();
>          if (!kvm_enabled()) {
>              while (penv) {
> @@ -1064,7 +1069,7 @@ void cpu_stop_current(void)
> 
>  void vm_stop(RunState state)
>  {
> -    if (!qemu_thread_is_self(&io_thread)) {
> +    if (qemu_cpu_is_vcpu()) {
>          qemu_system_vmstop_request(state);
>          /*
>           * FIXME: should not return to device code in case
>