From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34757)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TF4I4-0007Np-I6
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 10:33:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TF4I3-0000eC-NF
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 10:33:12 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:36880)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TF4I3-0000e7-GD
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 10:33:11 -0400
Received: by pbbrp12 with SMTP id rp12so7811826pbb.4
	for <qemu-devel@nongnu.org>; Fri, 21 Sep 2012 07:33:10 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <505C7AA4.9070800@twiddle.net>
Date: Fri, 21 Sep 2012 07:33:08 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1347978240-20260-1-git-send-email-rth@twiddle.net>
	<1347978240-20260-5-git-send-email-rth@twiddle.net>
	<20120918211148.GA20933@ohm.aurel32.net>
	<20120920220419.GC4457@ohm.aurel32.net>
In-Reply-To: <20120920220419.GC4457@ohm.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant
	comparisons
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 09/20/2012 03:04 PM, Aurelien Jarno wrote:
> +                } else if (tmp && temps[args[4-tmp]].state == TCG_TEMP_CONST) {

No need to test tmp here...

But thanks for the patch.  It'll be included in the next version.


r~