From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57710)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF5Cs-0008QI-EM
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 11:31:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF5Cm-0006vZ-OX
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 11:31:54 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:41016)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TF5Cm-0006vV-Iv
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 11:31:48 -0400
Received: by pbbrp12 with SMTP id rp12so7931997pbb.4
	for <qemu-devel@nongnu.org>; Fri, 21 Sep 2012 08:31:47 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <505C885E.6020507@redhat.com>
Date: Fri, 21 Sep 2012 17:31:42 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348236500-2565-1-git-send-email-quintela@redhat.com>
	<1348236500-2565-8-git-send-email-quintela@redhat.com>
In-Reply-To: <1348236500-2565-8-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/14] migration: make writes blocking
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Orit Wasserman <owasserm@redhat.com>, qemu-devel@nongnu.org

Il 21/09/2012 16:08, Juan Quintela ha scritto:
> -    s->fd = inet_connect(host_port, false, &in_progress, errp);
> +    s->fd = inet_connect(host_port, true, &in_progress, errp);

This makes the connect operation blocking.

Does this mean that Orit's patches for non-blocking connect are not
useful anymore?

Or should we instead leave this as is, and later call socket_set_block?

Paolo