From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF5Fi-00032s-J4 for qemu-devel@nongnu.org; Fri, 21 Sep 2012 11:34:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF5FY-0007Uq-OV for qemu-devel@nongnu.org; Fri, 21 Sep 2012 11:34:50 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:61784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF5FY-0007Ub-Iq for qemu-devel@nongnu.org; Fri, 21 Sep 2012 11:34:40 -0400 Received: by pbbrp12 with SMTP id rp12so7938053pbb.4 for ; Fri, 21 Sep 2012 08:34:40 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <505C890A.1080400@redhat.com> Date: Fri, 21 Sep 2012 17:34:34 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348236500-2565-1-git-send-email-quintela@redhat.com> <1348236500-2565-12-git-send-email-quintela@redhat.com> In-Reply-To: <1348236500-2565-12-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/14] buffered_file: don't flush on put buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel Il 21/09/2012 16:08, Juan Quintela ha scritto: > We call buffered_put_buffer with iothread held, and buffered_flush() does > synchronous writes. We only want to do the synchronous writes outside. > > Signed-off-by: Juan Quintela > --- > buffered_file.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/buffered_file.c b/buffered_file.c > index f4a788d..929b911 100644 > --- a/buffered_file.c > +++ b/buffered_file.c > @@ -107,12 +107,6 @@ static int buffered_put_buffer(void *opaque, const uint8_t *buf, int64_t pos, in > buffered_append(s, buf, size); > } > > - error = buffered_flush(s); > - if (error < 0) { > - DPRINTF("buffered flush error. bailing: %s\n", strerror(-error)); > - return error; > - } > - > return size; > } > This means that the buffer can grow to up to s->xfer_limit bytes. Perhaps you want to make the granularity (currently fixed to 100ms) a bit smaller, like 20-30 ms, if the bandwidth limit grows above say 100 MB/sec? This can be done on top of this series however. Reviewed-by: Paolo Bonzini