From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF68X-0006d2-PU for qemu-devel@nongnu.org; Fri, 21 Sep 2012 12:31:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF68T-0003bh-Mp for qemu-devel@nongnu.org; Fri, 21 Sep 2012 12:31:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF68T-0003bb-DD for qemu-devel@nongnu.org; Fri, 21 Sep 2012 12:31:25 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8LGVOC9000920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Sep 2012 12:31:24 -0400 Message-ID: <505C965B.1050504@redhat.com> Date: Fri, 21 Sep 2012 10:31:23 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348239340-29021-1-git-send-email-lcapitulino@redhat.com> <1348239340-29021-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1348239340-29021-3-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigB05E57E7A37BF01293DF7B38" Subject: Re: [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: akong@redhat.com, qemu-devel@nongnu.org, avi@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB05E57E7A37BF01293DF7B38 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/21/2012 08:55 AM, Luiz Capitulino wrote: > This commit fixes the problem by adding hex value support down > the QMP interface, qmp_send_key(). >=20 > +++ b/qapi-schema.json > @@ -2588,12 +2588,25 @@ > 'lf', 'help', 'meta_l', 'meta_r', 'compose' ] } > =20 > ## > +# @KeyValue > +# > +# Represents a keyboard key. > +#=20 > +# Since: 1.3.0 > +## > +{ 'union': 'KeyValue', > + 'data': { > + 'hex': 'int', Don't you find it a bit odd to name this 'hex', even though it works to do 'hex':32 as a synonym for 'hex':0x20? Should we instead name it 'value', since we don't care in what base the value was represented, only that JSON was able to decode the base into a value? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigB05E57E7A37BF01293DF7B38 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQXJZbAAoJEKeha0olJ0Nq2P0H/jMFgmEKOhGbGSCiFcqpPwYf jNl7HsUtfZsYnoBAot9UfGzJrvter9xYocyZXI9KY56EIzXvBRDaZ/sIPVCMqyKV bjcPNl6MjrJeSR6LYIoblyPo2MlRlAzhDp646bSnAII/Sb04PdGCg2ajOCu426fv jbVTgdAwPoggxtaIC1hzp5x2WmTk5n+RONt+i8RQ4tq4ePjwwwUoInwxoCN5tjrA CLTkLFYxkMz1ZRmrtBWkaiDfrchZVk7u2d3pwKZ3Qn4kD5UtobqAOTNjo7DKyK5b ceaP9tnQZa09kpYWeBSEpVo4sBv8MpcZ+q2Xocwvol6erfvI1ryzcJY5Qhgok60= =FOlb -----END PGP SIGNATURE----- --------------enigB05E57E7A37BF01293DF7B38--