From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: akong@redhat.com, qemu-devel@nongnu.org, avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/3]: qmp: send-key: accept key codes in hex
Date: Fri, 21 Sep 2012 10:32:00 -0600 [thread overview]
Message-ID: <505C9680.9090404@redhat.com> (raw)
In-Reply-To: <1348239340-29021-1-git-send-email-lcapitulino@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On 09/21/2012 08:55 AM, Luiz Capitulino wrote:
> o v2
>
> - re-write some commit logs
> - fix a possible issue with error handling in patch 2/3
>
> This actually fixes a regression introduced by the qapi conversion,
> please refer to patch 2/3 for details.
>
> It's also important to note that this series changes the QMP
> interface for the send-key command, but this shouldn't be a problem
> as we're still in development phase.
>
> hmp.c | 43 +++++++++++++++++++++-----------
> input.c | 75 ++++++++++++++++++++++++++++----------------------------
> qapi-schema.json | 19 +++++++++++---
> 3 files changed, 83 insertions(+), 54 deletions(-)
Series:
Reviewed-by: Eric Blake <eblake@redhat.com>
However, I have a bikeshed question on patch 2 that may require a respin.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
prev parent reply other threads:[~2012-09-21 16:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 14:55 [Qemu-devel] [PATCH v2 0/3]: qmp: send-key: accept key codes in hex Luiz Capitulino
2012-09-21 14:55 ` [Qemu-devel] [PATCH 1/3] input: qmp_send_key(): simplify Luiz Capitulino
2012-09-21 14:55 ` [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex Luiz Capitulino
2012-09-21 16:31 ` Eric Blake
2012-09-21 16:42 ` Luiz Capitulino
2012-09-21 17:26 ` Luiz Capitulino
2012-09-21 18:18 ` Eric Blake
2012-09-21 18:20 ` Eric Blake
2012-09-23 8:49 ` Avi Kivity
2012-09-21 18:20 ` Markus Armbruster
2012-09-21 14:55 ` [Qemu-devel] [PATCH 3/3] input: index_from_key(): drop unused code Luiz Capitulino
2012-09-21 16:32 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505C9680.9090404@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=avi@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).