From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF69A-0007TC-AG for qemu-devel@nongnu.org; Fri, 21 Sep 2012 12:32:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF696-0003u2-5y for qemu-devel@nongnu.org; Fri, 21 Sep 2012 12:32:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF695-0003tx-SE for qemu-devel@nongnu.org; Fri, 21 Sep 2012 12:32:04 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8LGW3eQ001129 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Sep 2012 12:32:03 -0400 Message-ID: <505C9680.9090404@redhat.com> Date: Fri, 21 Sep 2012 10:32:00 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348239340-29021-1-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1348239340-29021-1-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig09C04385A74CFF80FB9E285C" Subject: Re: [Qemu-devel] [PATCH v2 0/3]: qmp: send-key: accept key codes in hex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: akong@redhat.com, qemu-devel@nongnu.org, avi@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig09C04385A74CFF80FB9E285C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/21/2012 08:55 AM, Luiz Capitulino wrote: > o v2 >=20 > - re-write some commit logs > - fix a possible issue with error handling in patch 2/3 >=20 > This actually fixes a regression introduced by the qapi conversion, > please refer to patch 2/3 for details. >=20 > It's also important to note that this series changes the QMP > interface for the send-key command, but this shouldn't be a problem > as we're still in development phase. >=20 > hmp.c | 43 +++++++++++++++++++++----------- > input.c | 75 ++++++++++++++++++++++++++++--------------------= -------- > qapi-schema.json | 19 +++++++++++--- > 3 files changed, 83 insertions(+), 54 deletions(-) Series: Reviewed-by: Eric Blake However, I have a bikeshed question on patch 2 that may require a respin.= --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig09C04385A74CFF80FB9E285C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQXJaAAAoJEKeha0olJ0NqsXMH/isdZLLng0avvGSeo3czXwL9 /yFctjK0y+Ir3e1x7rr9Ht9o+LifphPmIdHcnBjuKWBngTIslDARDr+jWgdHBzmA 3GgqC7wCytnKrCUrYdPANPa7JNDfbAuTqPlYWLkWcZSFtLUWFxJTSX0oyU2Clib2 oDfxvB2RCrExk3sSdgSvqig8zoUVIO/WD6zGBFyAm6jd+frAgrIhBz13VmU8vr0S 4nBlrFp/IHYxoOT7sgbBns0AhTf8JExDUfuxn5su3tPMbj78yTJfKSJZhYkk3RZ0 A27NO0IUr32y77ulO9qG3aBW/KsmQ14maonF1Vd1l/PJHJB+T1rXmROoM4txuS8= =J3cv -----END PGP SIGNATURE----- --------------enig09C04385A74CFF80FB9E285C--