From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF7hU-0001mi-RI for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:11:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF7hT-0007v2-Km for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:11:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF7hT-0007ux-DD for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:11:39 -0400 Message-ID: <505CADD4.5070407@redhat.com> Date: Fri, 21 Sep 2012 12:11:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348247243-12446-1-git-send-email-lcapitulino@redhat.com> <1348247243-12446-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1348247243-12446-2-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig78A0731E1B01E050C09D403E" Subject: Re: [Qemu-devel] [PATCH 1/3] qmp: dump-guest-memory: improve schema doc (again) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, d.hatayama@jp.fujitsu.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig78A0731E1B01E050C09D403E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/21/2012 11:07 AM, Luiz Capitulino wrote: > o Add a note about memory allocation with paging=3Dtrue > o Fix indentation >=20 > Signed-off-by: Luiz Capitulino > --- > qapi-schema.json | 32 ++++++++++++++++++++------------ > 1 file changed, 20 insertions(+), 12 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 14e4419..3d93ebe 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1982,26 +1982,33 @@ > # supported on i386 and x86_64. > # > # @paging: if true, do paging to get guest's memory mapping. This allo= ws > -# using gdb to process the core file. However, setting @paging to fals= e > -# may be desirable because of two reasons: > +# using gdb to process the core file. You've got a TAB in there, that made it hard to see what the intended indentation really is. The rest of the file doesn't have TABs, so you need to respin this. > +# IMPORTANT: this option can make QEMU allocates several gigabytes= s/allocates/allocate/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig78A0731E1B01E050C09D403E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQXK3UAAoJEKeha0olJ0NqhIoH+QEtSE3crohSm4QA50IhPifT XSTyUgyLpszyY+lRKqdsvDS+rnjA/6wJE6BISpV0zEWZKEY0uR/tkfSZtR0C5tE2 4XwHYuQ0Rg0OUUlksAeebFwJrJ9mEK1xchfWj5aIbdgxnmelwrtF0BwlXXeGJX7d cmlLO2llz4GXxH6DtGWMUni0aQTtvC6ZEOsMOi2CF5X174glM1300X6cooNJgU+o jS4HPFemLQU+/TBw0eoGekrChN9Scp7MrJXyYx8Io2Dfnebt7NVHxYvHXZZXc3Ht YVCxg6bKEv6BTjzR2hKhtscKLOviMd/CjbpaPZvLCNgR/jp0rTRrq/62YkAZvUc= =8hix -----END PGP SIGNATURE----- --------------enig78A0731E1B01E050C09D403E--