From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com,
qemu-devel@nongnu.org, d.hatayama@jp.fujitsu.com,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] hmp: dump-guest-memory: hardcode protocol argument to file:
Date: Fri, 21 Sep 2012 12:13:39 -0600 [thread overview]
Message-ID: <505CAE53.2040907@redhat.com> (raw)
In-Reply-To: <1348247243-12446-4-git-send-email-lcapitulino@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On 09/21/2012 11:07 AM, Luiz Capitulino wrote:
> Today, it's necessary to specify the protocol you want to use
> when dumping the guest memory, for example:
>
> (qemu) dump-guest-memory file:/tmp/guest-memory
>
> This has a few issues:
>
> 1. It's cumbersome to type
> 2. We loose file path autocompletion
> 3. Being able to specify fd:X in HMP makes little sense for humans
>
> Because of these reasons, hardcode the 'protocol' argument to
> 'file:' in HMP.
No impact to libvirt as a QMP client, and we've already declared that
HMP can change for better UI even if it is not back-compatible.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-09-21 18:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 17:07 [Qemu-devel] [PATCH 0/3]: qmp/hmp: dump-guest-memory fixes Luiz Capitulino
2012-09-21 17:07 ` [Qemu-devel] [PATCH 1/3] qmp: dump-guest-memory: improve schema doc (again) Luiz Capitulino
2012-09-21 18:11 ` Eric Blake
2012-09-21 17:07 ` [Qemu-devel] [PATCH 2/3] qmp: dump-guest-memory: don't spin if non-blocking fd would block Luiz Capitulino
2012-09-21 18:30 ` Eric Blake
2012-09-24 6:27 ` Wen Congyang
2012-09-24 13:34 ` Luiz Capitulino
2012-09-25 8:19 ` Wen Congyang
2012-09-25 9:01 ` Markus Armbruster
2012-09-25 9:13 ` Wen Congyang
2012-09-25 9:14 ` Wen Congyang
2012-09-21 17:07 ` [Qemu-devel] [PATCH 3/3] hmp: dump-guest-memory: hardcode protocol argument to file: Luiz Capitulino
2012-09-21 18:13 ` Eric Blake [this message]
2012-09-25 8:48 ` Markus Armbruster
2012-09-25 12:02 ` Luiz Capitulino
2012-09-25 10:10 ` Wen Congyang
2012-09-25 8:54 ` [Qemu-devel] [PATCH 0/3]: qmp/hmp: dump-guest-memory fixes Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2012-09-26 18:56 [Qemu-devel] [PATCH v2 0/3] " Luiz Capitulino
2012-09-26 18:56 ` [Qemu-devel] [PATCH 3/3] hmp: dump-guest-memory: hardcode protocol argument to "file:" Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505CAE53.2040907@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=jan.kiszka@siemens.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).