From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF7jW-0003Mr-5F for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:13:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF7jV-0008Il-0c for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:13:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF7jU-0008If-NM for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:13:44 -0400 Message-ID: <505CAE53.2040907@redhat.com> Date: Fri, 21 Sep 2012 12:13:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348247243-12446-1-git-send-email-lcapitulino@redhat.com> <1348247243-12446-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1348247243-12446-4-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig204207DCB00959C3D77E77AD" Subject: Re: [Qemu-devel] [PATCH 3/3] hmp: dump-guest-memory: hardcode protocol argument to file: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, d.hatayama@jp.fujitsu.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig204207DCB00959C3D77E77AD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/21/2012 11:07 AM, Luiz Capitulino wrote: > Today, it's necessary to specify the protocol you want to use > when dumping the guest memory, for example: >=20 > (qemu) dump-guest-memory file:/tmp/guest-memory >=20 > This has a few issues: >=20 > 1. It's cumbersome to type > 2. We loose file path autocompletion > 3. Being able to specify fd:X in HMP makes little sense for humans >=20 > Because of these reasons, hardcode the 'protocol' argument to > 'file:' in HMP. No impact to libvirt as a QMP client, and we've already declared that HMP can change for better UI even if it is not back-compatible. Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig204207DCB00959C3D77E77AD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQXK5UAAoJEKeha0olJ0NqzRwH/jXy1wmAVSeC1/tZKemSNIYr 3vV2z5nsJKv/YsfvLv/qZBRYxxkTNDYZ5bN0SCZnm1rEvdZ7VxAqWG3kLprnEGQL E+FNOvc/YYtsxBarHwi3Sp1iTVT/9fqxgwgAASZqEjyCHW5G8uvPFOu5wM2NMB3M BieXJ6+pL+xuqgB1g6TYqlltl939Hlc7mhafxRHKKFekjzqXhHaqve4YLcp0CRa7 lbExB4xlXFcaYPq2TOKuPTX9+/MR4KMIMBP6PUKXyFSP/SEywr9je8Mje/wTIm55 Fg/b4McQu6YV3mbHvv3bK0u206VRBadLZh7JnOAQstsi5bgKK4l9uxAhOsUluOw= =QR8J -----END PGP SIGNATURE----- --------------enig204207DCB00959C3D77E77AD--