From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF7oI-00083x-L8 for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:18:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF7oE-0001j1-HT for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:18:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF7oE-0001ix-94 for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:18:38 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8LIIb3M025194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Sep 2012 14:18:37 -0400 Message-ID: <505CAF7C.5040403@redhat.com> Date: Fri, 21 Sep 2012 12:18:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348239340-29021-1-git-send-email-lcapitulino@redhat.com> <1348239340-29021-3-git-send-email-lcapitulino@redhat.com> <505C965B.1050504@redhat.com> <20120921134234.5d836bc5@doriath.home> <20120921142634.2d4707c4@doriath.home> In-Reply-To: <20120921142634.2d4707c4@doriath.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4967C64303685059CD86DF6D" Subject: Re: [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: akong@redhat.com, qemu-devel@nongnu.org, avi@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4967C64303685059CD86DF6D Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 09/21/2012 11:26 AM, Luiz Capitulino wrote: > On Fri, 21 Sep 2012 13:42:34 -0300 > Luiz Capitulino wrote: >=20 >>>> +{ 'union': 'KeyValue', >>>> + 'data': { >>>> + 'hex': 'int', + 'qcode': 'QKeyCode', >>> >>> Don't you find it a bit odd to name this 'hex', even though it works = to >>> do 'hex':32 as a synonym for 'hex':0x20? Should we instead name it >>> 'value', since we don't care in what base the value was represented, >>> only that JSON was able to decode the base into a value? >> >> Yes, that's a good point. I'll respin. >=20 > Actually, this also has drawbacks: >=20 > keylist->value->kind =3D KEY_VALUE_KIND_VALUE; > keylist->value->value =3D value; > Any better ideas? Maybe s/hex/number/, as in: JSON: 'number':0x20 C code: keylist->value->number =3D number; that is, you are passing the value either as a keycode name, or as a numb= er. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4967C64303685059CD86DF6D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQXK98AAoJEKeha0olJ0NqCMoH/A1Ov6RfUYRv92mGU/Wf3lWr sB1SC6cLwfn2+v/s4AX10BQIaLGKRD95q6tmunrEL6Hbbz/9/mC6IVBVQ3UYQLkU +f+akgjVOWLZx1yk9kDcI1yRsvs33OS6ES51rTUlKBFJrEpxYg/QFhhh0A4ugFJs iQXrjyY0NdfMyCJnj7P/woFzCAasM5iU0QBi7vKJipUyl2WH7tZfqPbkCq9wakN9 kpXKOsIsxEncv7ItwxFvruSBkaj0UsZ8yemusr01KUknoyf/d23H45l3ZOTHRqRf kQEGZciDpFYquM5mGkpvxdmGMAJ9TARkGG4EdobZatOL7DpNDk3Wb71AfcKCZZI= =G/UK -----END PGP SIGNATURE----- --------------enig4967C64303685059CD86DF6D--