From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF7oJ-00087h-NM for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:18:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF7oI-0001je-KM for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:18:43 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:40678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF7oI-0001jN-EH for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:18:42 -0400 Received: by padfb10 with SMTP id fb10so527402pad.4 for ; Fri, 21 Sep 2012 11:18:41 -0700 (PDT) Sender: Richard Henderson Message-ID: <505CAF7F.9050505@twiddle.net> Date: Fri, 21 Sep 2012 11:18:39 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1348245809-13482-1-git-send-email-aurelien@aurel32.net> <1348245809-13482-5-git-send-email-aurelien@aurel32.net> In-Reply-To: <1348245809-13482-5-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/10] tcg/mips: don't use global pointer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 09/21/2012 09:43 AM, Aurelien Jarno wrote: > Don't use the global pointer in TCG, in case helpers try access global > variables. Err.. isn't the GP computed at the entry point of functions that need to use it? That said, under n32 and n64 abis it is call-saved; under o32 it's call-clobbered. So by itself this is still a fix for new-abis, since we don't save it in the prologue. OTOH, this does suggest an alternate solution... ;-) r~